Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BGP policy's origin attributes #434

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Support BGP policy's origin attributes #434

merged 2 commits into from
Jun 18, 2024

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Jun 13, 2024

No description provided.

@wenovus wenovus requested a review from DanG100 June 13, 2024 18:26
@wenovus
Copy link
Contributor Author

wenovus commented Jun 13, 2024

BGP tests passing locally.

Base automatically changed from update-gobgp to main June 17, 2024 16:37
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551430063

Details

  • 10 of 16 (62.5%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 2.807%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bgp/ocgobgp.go 10 12 83.33%
bgp/gobgp.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.003%
Covered Lines: 18474
Relevant Lines: 658056
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551430063

Details

  • 10 of 16 (62.5%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 2.807%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bgp/ocgobgp.go 10 12 83.33%
bgp/gobgp.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.003%
Covered Lines: 18474
Relevant Lines: 658056
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551430063

Details

  • 10 of 16 (62.5%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 2.807%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bgp/ocgobgp.go 10 12 83.33%
bgp/gobgp.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.003%
Covered Lines: 18474
Relevant Lines: 658056
💛 - Coveralls

@wenovus wenovus merged commit 51f604f into main Jun 18, 2024
10 checks passed
@wenovus wenovus deleted the support-origin-attributes branch June 18, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenovus @DanG100